Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

Philipp Wiesemann
Fixed typo in log message in testime program.
Philipp Wiesemann
aix: Fixed compile error.
Philipp Wiesemann
Updated generated configure script.
Ryan C. Gordon
qnx: fixed potential buffer overflow.
Ryan C. Gordon
sndio: More improvements to the OpenBSD audio target (thanks, kdrakehp!).

Fixes Bugzilla #3705.
  • sdl-android: compile failed -  stdio
  • sdl-linux-amd64: configure failed -  stdio
  • sdl-macosx-unix: compile failed -  stdio
  • sdl-nacl: compile failed -  stdio
Alex Szpakowski
macOS: Replace uses of deprecated Cocoa enum names with modern/consistent equivalents.
  • sdl-macosx-static-analysis: compile failed -  stdiowarnings (6)
  • sdl-macosx-unix: compile failed -  stdio
  • sdl-macosx-xcode: compile failed -  stdio
Sam Lantinga
Fixed bug 3609 - Windows build fails due to conflicting types for 'XINPUT_GAMEPAD_EX'

Ozkan Sezer

(In reply to Ryan C. Gordon from comment #9)
> I've put this patch in as https://hg.libsdl.org/SDL/rev/117d4ce1390e ...can
> you verify this works on the latest MinGW?
>
> Thanks,
> --ryan.


This patch is wrong: the structure in question has nothing to do with any
gcc version in use.  I suggest reverting this adding a conigury check for
it, instead.  Something like the following should do it: (configure needs
regenerating.)
Philipp Wiesemann
aix: Fixed audio debug output.

DEBUG_AUDIO is checked with #ifdef not #if.
Philipp Wiesemann
netbsd: Fixed comment.
Philipp Wiesemann
netbsd: Removed unused field.
Philipp Wiesemann
Fixed missing audio entries in configure summary.
Philipp Wiesemann
qnx: Fixed configure script setting wrong variable.
Alex Szpakowski
macOS: Address more compiler warnings when building with a recent deployment target.
Ryan C. Gordon
audio: trying to pacify static analysis.
Ryan C. Gordon
power: whoops, that should be "==" not "!=".
Sam Lantinga
Fixed bug 3705 - Add capture support to the sndio backend

kdrakehp

The attached patch adds capture support to the sndio backend.

The patch also allows the `OpenDevice' function to accept arbitrary device names.
  • sdl-android: compile failed -  stdio
  • sdl-linux-amd64: configure failed -  stdio
  • sdl-macosx-unix: compile failed -  stdio
  • sdl-nacl: compile failed -  stdio
Ryan C. Gordon
x11: pass a long to XChangeProperty, not an int.

The Xlib documentation demands that 32-bit values here be passed in a long,
even when long itself isn't a 32-bit value. Otherwise libx11 might read
memory incorrectly.

Fixes Bugzilla #3692.
Philipp Wiesemann
haiku: Fixed using wrong constant for internal error handling.

SDL_CreateWindow() worked because ENOMEM is negative on Haiku.
Sam Lantinga
Fixed bug 3699 - Shaped windows are distorted unless width is divisible by 8

Bogomancer

On X11, windows created using the shaped window API appear distorted unless the width of the shape surface is divisible by 8.

Steps to reproduce:

    1) Use your favorite image editor to resize one of the images in test/shapes/ to a width that's not a multiple of 8.
    2) Compile and run test/testshape.c on the image you edited.
    3) The shaped window will appear twisted and distorted.

It appears the bug was not caught sooner because all the test images are either 640 or 256 pixels wide.

I tracked down the bug to SDL_CalculateShapeBitmap() in SDL_shape.c. The shape surface is reduced to a 1-bit-per-pixel mask, but the original code doesn't take into account that X11 apparently wants each scanline to begin on a new byte.
Philipp Wiesemann
haiku: Fixed compiling without OpenGL support.
Sam Lantinga
Updated Visual Studio 2008 project
Sam Lantinga
Fixed bug 3697 - Main thread gets stuck on left mouse down

Amruth Raj

- My app runs in full screen to play video(I use SDL_WINDOW_FULLSCREEN_DESKTOP)
- Cmd-tab to go out of full screen to another app
- Cmd-tab again to get back to my app
- Press left mouse button at one of the edges of the screen, don't release yet.
After this point the main thread is stuck until I release the left mouse button and hence video rendering doesn't happen anymore.

On debugging more, I see that thread 0 is stuck as shown below with sendEvent processing left mouse down. It comes out only after it receives a left mouse up. There are some frames below which show NSWindowResizing, but my window flag doesn't have SDL_WINDOW_RESIZABLE set.

Thread 0:: CrBrowserMain Dispatch queue: com.apple.main-thread
0 libsystem_kernel.dylib 0x00007fffbe13d34a mach_msg_trap + 10
1 libsystem_kernel.dylib 0x00007fffbe13c797 mach_msg + 55
2 com.apple.CoreFoundation 0x00007fffa889d434 __CFRunLoopServiceMachPort + 212
3 com.apple.CoreFoundation 0x00007fffa889c8c1 __CFRunLoopRun + 1361
4 com.apple.CoreFoundation 0x00007fffa889c114 CFRunLoopRunSpecific + 420
5 com.apple.HIToolbox 0x00007fffa7dfdebc RunCurrentEventLoopInMode + 240
6 com.apple.HIToolbox 0x00007fffa7dfdcf1 ReceiveNextEventCommon + 432
7 com.apple.HIToolbox 0x00007fffa7dfdb26 _BlockUntilNextEventMatchingListInModeWithFilter + 71
8 com.apple.AppKit 0x00007fffa6396a54 _DPSNextEvent + 1120
9 com.apple.AppKit 0x00007fffa6b127ee -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796
10 com.apple.AppKit 0x00007fffa66f568d +[NSWindow(NSWindowResizing) _mouseHysteresisCheck:withExpiration:andDistance:finalMouseLocation:] + 525
11 com.apple.AppKit 0x00007fffa65eedb5 -[NSWindow(NSWindowResizing) _hitTestWithHysteresisCheck:forEvent:allowWindowDragging:] + 394
12 com.apple.AppKit 0x00007fffa6c8f0db -[NSWindow(NSEventRouting) _handleMouseDownEvent:isDelayedEvent:] + 1873
13 com.apple.AppKit 0x00007fffa6c8ca6c -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 1942
14 com.apple.AppKit 0x00007fffa6c8bf0a -[NSWindow(NSEventRouting) sendEvent:] + 541
15 org.libsdl.SDL2 0x000000010d46d74a -[SDLWindow sendEvent:] + 90
16 com.apple.AppKit 0x00007fffa6b10681 -[NSApplication(NSEvent) sendEvent:] + 1145
17 org.libsdl.SDL2 0x000000010d46532b -[SDLApplication sendEvent:] + 139
18 org.libsdl.SDL2 0x000000010d466b2f Cocoa_PumpEvents + 495
19 org.libsdl.SDL2 0x000000010d44c1d5 SDL_PumpEvents_REAL + 53
20 org.libsdl.SDL2 0x000000010d44c2f5 SDL_WaitEventTimeout_REAL + 53
21 org.libsdl.SDL2 0x000000010d44c2b7 SDL_PollEvent_REAL + 23
22 org.libsdl.SDL2 0x000000010d51bb24 SDL_PollEvent + 36
23 libTest.dylib 0x000000010cf3e0e8 SDLEventProcessor::processEvents(int) + 568
24 Test 0x000000010cde6bba BrowserApp::RunAppMessageLoop(BAInstData*, CefStringBase, CefStringBase) + 810
25 Test 0x000000010ce04bbc main + 17980
26 libdyld.dylib 0x00007fffbe016235 start + 1

I further noticed that while entering full screen in SDL_cocoawindow.m NSResizableWindowMask is set. If I clear it inside windowDidEnterFullScreen, then, the issue doesn't repro.

This is discussed at https://discourse.libsdl.org/t/main-thread-gets-stuck-on-left-mouse-down/22753/3 and thanks to Eric for the pointers.
Sam Lantinga
Fixed bug 3410 - SDL_WINDOW_HIDDEN flag is inaccurate.

Jason Wyatt

After hiding the window, SDL_WINDOW_HIDDEN/SDL_WINDOW_SHOWN flags on a window are correctly updated. However on the next SDL_PumpEvents, they are set incorrectly.

This appears to be because X11_GetNetWMState does not check whether the _NET_WM_STATE property exists (it shouldn't on unmapped windows, see https://specifications.freedesktop.org/wm-spec/wm-spec-1.3.html#idm140130317598336). This results in an empty list of atoms for the state, which would imply that the window is not hidden.

(Seen on Fedora 24, Gnome)

--

Dan Ginsburg

More details on my proposed patch: I am on Kubuntu 16.04.2.  I ran into this same bug, but with Jason's patch I found that actualType != None was true so the SDL_WINDOW_HIDDEN would still not be set.  My fix instead is to explicitly check for whether the window is unmapped rather than relying on the returned values in XGetWindowProperty.
  • sdl-android: compile failed -  stdio
  • sdl-linux-amd64: configure failed -  stdio
  • sdl-macosx-unix: compile failed -  stdio
  • sdl-nacl: compile failed -  stdio
Ryan C. Gordon
power: Linux /sys/class testing should skip "device" scopes.

(the PS4 game controllers report their batteries through this interface, which
is cool, but not helpful for powering the rest of the system.  :)  )
Philipp Wiesemann
qnx: Removed unused bootstrap declaration.

QNX_bootstrap is the VideoBootStrap. QSAAUDIO_bootstrap is still there.
Philipp Wiesemann
haiku: Fixed memory leak if destroying window.
Alex Szpakowski
iOS: Use modern replacements for deprecated functions, when available.
Sam Lantinga
Fixed bug 3703 - Missing media keys support on Amazon Fire TV remote control

Holger Schemel

Summary: This patch adds support for key events for the "rewind" and "fast forward" media keys on the Amazon Fire TV remote control.

How to reproduce the problem: Run Android build of SDL2 application on the Amazon Fire TV (tested with "stick" version) and log key events.

Expected behaviour: Every key pressed on the Fire TV remote control should result in a corresponding key event (pressed/released).

Observed behaviour: Of the bottom row of buttons on the Fire TV remote control, only the "play/pause" (middle) button generates a key event, while the "rewind" (left) and "fast forward" (right) buttons to not generate any event at all.

The attached patch adds support for these two missing buttons/keys.

Note 1: Some missing definitions were added for the already existing key codes SDL_SCANCODE_APP1 and SDL_SCANCODE_APP2 (to keep up the correct order of enumerations / array positions when adding the two new key codes).

Note 2: Definitions in "scancodes_linux.h" and "scancodes_xfree86.h" (to also add support for these keys on other platforms) were added without testing. However, I was unable to find corresponding definitions for these two media keys for Windows and Mac OS X.

Note 3: I have also updated the (broken) link to the USB usage page standard PDF document (comment in "include/SDL_scancode.h").
  • sdl-android: compile failed -  stdio
  • sdl-linux-amd64: configure failed -  stdio
  • sdl-macosx-unix: compile failed -  stdio
  • sdl-nacl: compile failed -  stdio
Sam Lantinga
Fixed bug 3688 - cmake / pthread check related patch proposal

Juha Niemimäki

Fix for PTHREAD_MUTEX_RECURSIVE_NP check and restoring the original flags

Two fixes proposed:

1) Looks like there is a copy-paste issue regarding PTHREAD_MUTEX_RECURSIVE_NP check.

2) Compiler flag restoration doesn't look symmetrical regarding if/endif blocks. Moved to an outer block (if PTHREADS).
Philipp Wiesemann
qnx: Fixed setting a field twice.
Alex Szpakowski
macOS: Fix compilation when using 10.11 or earlier to build.
Alex Szpakowski
Fix a potential crash in macOS 10.7 and earlier.
Ryan C. Gordon
sndio: fixed poll() call (thanks, kdrakehp!).

Fixes Bugzilla #3705.
  • sdl-android: compile failed -  stdio
  • sdl-linux-amd64: configure failed -  stdio
  • sdl-macosx-unix: compile failed -  stdio
  • sdl-nacl: compile failed -  stdio
Sam Lantinga
Fixed build on older Mac OS X SDKs
Philipp Wiesemann
Fixed compiler warning about redundant declaration.

SDL_RecordGesture() is already in the gesture header with additional specifiers.
Sam Lantinga
Fixed bug 3689 - MMX YUV renderer crash

felix

The functions in src/render/SDL_yuv_mmx.c contain the following inline assembly snippet:

        /* tap dance to workaround the inability to use %%ebx at will... */
        /*  move one thing to the stack... */
        "pushl $0\n"  /* save a slot on the stack. */
        "pushl %%ebx\n"  /* save %%ebx. */
        "movl %0, %%ebx\n"  /* put the thing in ebx. */
        "movl %%ebx,4(%%esp)\n"  /* put the thing in the stack slot. */
        "popl %%ebx\n"  /* get back %%ebx (the PIC register). */

Here's how it ended up in a binary on my old laptop:

  0xb5c17dbd <ColorRGBDitherYV12MMX1X+93>: push  $0x0
  0xb5c17dbf <ColorRGBDitherYV12MMX1X+95>: push  %ebx
  0xb5c17dc0 <ColorRGBDitherYV12MMX1X+96>: mov    0xc(%esp),%ebx
  0xb5c17dc4 <ColorRGBDitherYV12MMX1X+100>: mov    %ebx,0x4(%esp)
  0xb5c17dc8 <ColorRGBDitherYV12MMX1X+104>: pop    %ebx

Apparently the compiler, oblivious to the fact that the assembly snippet manipulates the %esp register, decided to refer to the operand via that same register instead of via %ebp (I believe -fomit-frame-pointer enables this). This causes %ebx to be loaded with the wrong value, which later leads to a null pointer dereference.

Recent GCC can use the %ebx register normally: <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47602#c16>. There is even an explicit constraint "b" for allocating it.
  • sdl-android: compile failed -  stdio
  • sdl-linux-amd64: configure failed -  stdio
  • sdl-macosx-unix: compile failed -  stdio
  • sdl-nacl: compile failed -  stdio
Sam Lantinga
Added support for an XBox One wired controller for Leo Lännenmäki
Ryan C. Gordon
Support for QNX 7.0 (thanks, Elad!).

Fixes Bugzilla #3686.
Alex Szpakowski
macOS: Expose more display modes on retina screens. Fixes an issue found in BZFlag.
Sam Lantinga
Fixed bug 3696 - SDL_ShowMessageBox displays different error from intended

Mark Callow

SDL_ShowMessageBox calls SDL_CaptureMouse which, in the UIKit driver, raises a “That operation is not supported” error, overwriting the SDL error that an application may be trying to report.

This is because UIKit SDL_CaptureMouse returns SDL_Unsupported() which ends up calling SDL_SetError() which has the following code:

    /* If we are in debug mode, print out an error message */
    SDL_LogDebug(SDL_LOG_CATEGORY_ERROR, "%s", SDL_GetError());

The SDL_GetError call here overwrites the static buffer…..

Although an application can avoid this by using SDL_GetErrorMsg(char* errstr,  int maxlen) to avoid the static buffer, SDL should be fixed.

The fix is simple. In SDL_SetError change

    SDL_LogDebug(SDL_LOG_CATEGORY_ERROR, "%s", SDL_GetError());

to

    SDL_LogDebug(SDL_LOG_CATEGORY_ERROR, "%s", error);

where error is the pointer to the buffer where it assembled the message.