Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

Ryan C. Gordon
coreaudio: Use the standard SDL audio thread instead of spinning a new one.

Fixes corner cases, like the audio callback not firing if the device is
disconnected, etc.
Sam Lantinga
Fixed bug where an SDL window that was activated while hidden could never be shown.

Test code:
{
SDL_Window *win = SDL_CreateWindow( "Dummy", SDL_WINDOWPOS_CENTERED, SDL_WINDOWPOS_CENTERED, 128, 128, SDL_WINDOW_HIDDEN );
SDL_SysWMinfo info;
SDL_VERSION( &info.version );
SDL_GetWindowWMInfo( win, &info );
SetActiveWindow( info.info.win.window );
{
DWORD then = SDL_GetTicks();
while ( ( SDL_GetTicks() - then ) < 3000 )
{
SDL_Event evt;
SDL_PollEvent( &evt );
}
SDL_ShowWindow( win );

then = SDL_GetTicks();
while ( ( SDL_GetTicks() - then ) < 3000 )
{
SDL_Event evt;
SDL_PollEvent( &evt );
}
}
SDL_DestroyWindow( win );
}
Sam Lantinga
Fixed bug 4135 - Broken symlink libSDL2.so since rev11940

Tiago O.

Symlink points to the wrong folder, and target will always have debug postfix, so it'll be broken for other build types.
Sam Lantinga
Fixed bug 3804 - Message box on Windows truncates button ID

Simon Hug

I just wanted to fix a simple compiler warning in SDL_ShowMessageBox on Windows (which Sam fixed recently) and ended up finding some issues.

Attached patch fixes these issues:

- Because Windows only reports the lower 16 bits of the control identifier that was pushed, the button IDs used by SDL (C type int, most likely 32 bits) can get cut off.

- The documentation states (somewhat ambiguously) that the button ID will be -1 if the dialog was closed, but the current code sets 0. For SDL 2.1, I think this should be a return code of SDL_ShowMessageBox itself. That will free up the button ID and it seems a more appropriate place for signaling this event.

- Ampersands in controls will create mnemonics on Windows (underlined letters that, if combined with the Alt key, will push the button). I was thinking of adding a hint or flag to let the users enable it, but that might have unexpected results.

- When the size of the text gets calculated, it doesn't use the same parameters as the static control. This can cut off text or wrap it weirdly.

- On Windows, the Tab key is used to switch between control groups and sometimes between buttons in dialogs. This didn't seem to work correctly.

Attached patch also adds:

- Icons. Just the system ones that can be loaded with the ordinals IDI_ERROR, IDI_WARNING and IDI_INFORMATION.

- A button limit of 2^16 - 101.

- Some more specific error messages, but they never reach the user because how SDL_ShowMessageBox handles them if an implementation returns with an error.
Sam Lantinga
Added support for adjusting thread priorities using Linux RealtimeKit

Michael Sartain

This is a quick pass at adding Linux RealtimeKit thread priority support to SDL.

It allows me to bump the thread priority to high without root privileges or setting any caps, etc.

rtkit readme here:
    http://git.0pointer.net/rtkit.git/tree/README
Sam Lantinga
Added mapping for the ASUS Gamepad removing the guide button, which doesn't generate events even though it's reported in the Android APIs.
Sam Lantinga
Use the real controller name for game controllers on iOS and Apple TV
Sam Lantinga
Delay delivery of the pause button release on MFI controllers so it doesn't happen in the same frame as the button press
Sam Lantinga
Added SDL_THREAD_PRIORITY_TIME_CRITICAL
  • sdl-android: compile failed -  stdio
  • sdl-freebsd-amd64: compile failed -  stdio
  • sdl-freebsd-amd64-clang: compile failed -  stdio
  • sdl-haiku: compile failed -  stdio
  • sdl-ios-xcode: compile failed -  stdio
  • sdl-kfreebsd-amd64: compile failed -  stdiowarnings (1)
  • sdl-macosx-unix: compile failed -  stdio
  • sdl-macosx-xcode: compile failed -  stdio
  • sdl-openbsd-amd64: compile failed -  stdio
Sam Lantinga
Added Android custom cursor implementation
This is commented out in SDLActivity.java, with the note #CURSORIMPLEENTATION because it requires API 24, which is higher than the minimum required SDK
Sam Lantinga
Progress fixing bug 4100 - errors and warnings after changeset 11917

Ozkan Sezer 2018-03-02 20:02:37 UTC
http://hg.libsdl.org/SDL/rev/5ce3f8bf8381 resulted in an error and
two warnings when compiled with mingw.

1.  Error from SDL_windowstaskdialog.h:
In file included from src/video/windows/SDL_windowsmessagebox.c:29:0:
src/video/windows/SDL_windowstaskdialog.h:23:54: error: expected ')' before 'HWND'

This is fixed by removing unnecessary annotations:

2.  Warning from SDL_assert.c:
src/SDL_assert.c: In function 'SDL_ExitProcess':
src/SDL_assert.c:138:1: warning: 'noreturn' function does return

Indeed ExitProcess() is prototyped with DECLSPEC_NORETURN, but
TerminateProcess() is not.  This can be rectified by adding an
exit() call in there. Do NOTE, however, that requires building
with a libc:

3.  Warning from SDL_windowsmessagebox.c:
src/video/windows/SDL_windowsmessagebox.c: In function 'WIN_ShowMessageBox':
src/video/windows/SDL_windowsmessagebox.c:513:9: warning: 'nCancelButton' may be used uninitialized in this function

My lazy solution was manually initializing nCancelButton to 0.
Sam Lantinga
Added Mac OpenGL ES configure support
Sam Lantinga
Fixed setting the layer drawable size
Without this change the drawable had a size of 0 and the metal renderer asserted because the projection matrix wasn't set.
Saad Khattak
Added debug postfix to install command and fixed library path
Sam Lantinga
Improved error messages when Vulkan isn't configured (thanks Daniel Gibson!)
Sam Lantinga
Added tag release-2.0.8 for changeset f1084c419f33
Sam Lantinga
Handle NULL return from SDL_DBus_GetContext()
Sam Lantinga
Fixed bug 4102 - define _WIN32_WINNT_WIN7 if not already defined

Ozkan Sezer

The following patch defines _WIN32_WINNT_WIN7 if it is not already
defined in core/windows/SDL_windows.c,  similar to what is already
there for _WIN32_WINNT_VISTA.
Sam Lantinga
Generalized the handling of instantaneous guide button presses so there's a minimum of 100 ms between guide button press and release.
This happens with at least the following controllers: All Apple MFI controllers, ASUS Gamepad, XiaoMi Bluetooth Controller
  • sdl-android: compile failed -  stdio
  • sdl-emscripten: compile failed -  stdio
  • sdl-freebsd-amd64-clang: compile failed -  stdio
  • sdl-ios-xcode: compile failed -  stdio
  • sdl-macosx-static-analysis: compile failed -  stdiowarnings (21)
  • sdl-macosx-unix: compile failed -  stdio
  • sdl-macosx-xcode: compile failed -  stdio
  • sdl-nacl: compile failed -  stdio
Sam Lantinga
Fixed bug 4103 - SDL_cpuinfo.h provokes warnings with -Wundef on non-x86 hosts

Felix Geyer

Forwarding from https://bugs.debian.org/892087 quoting verbatim:

The SDL2 header SDL_cpuinfo.h generates gcc warnings if the program using
it compiles with the -Wundef warning. (In particular, this means that QEMU
builds using it fail on at least sparc hosts, since QEMU dev builds
use both -Wundef and -Werror.).

/usr/include/SDL2/SDL_cpuinfo.h:63:5: warning: "HAVE_IMMINTRIN_H" is not defined, evaluates to 0 [-Wundef]
#if HAVE_IMMINTRIN_H && !defined(SDL_DISABLE_IMMINTRIN_H)
Sam Lantinga
Reimplemented Android cursor API support using reflection so it builds with older SDKs
Sam Lantinga
Include a USB VID/PID for Apple MFI controllers
This is just placeholder VID/PID, but allows code that works with VID/PID to identify the MFI controllers easily.
Sam Lantinga
Fixed bug 4101 - configure needs regenerating after changeset 11894
Sam Lantinga
Added SDL_LinuxSetThreadPriority() to directly set the priority of a Linux thread (tid)
This function tries using RealtimeKit connecting over DBUS as needed.
Sam Lantinga
Try to dynamically create a default Android game controller mapping based on the buttons and axes on the controller.
Include the controller USB VID/PID in the GUID where possible, as we do on other platforms.
MichaƂ Janiszewski
Fix ARM builds with MSVC
Sam Lantinga
Added a mapping for the latest firmware for the Xbox One S controller on Android
Sam Lantinga
SDL:

On Windows, have SDL_ShowWindow() not activate the window if the window has the WS_EX_NOACTIVATE window flag.
Ryan C. Gordon
windows: Restore patches for Task Dialogs and TerminateProcess().

2.0.8 has shipped, these can live in revision control now!
Sam Lantinga
Added SDL_GameControllerMappingForDeviceIndex() to get the mapping for a controller before it's opened
Bastien Bouclet
Fix the include path in the installed CMake target import file

Previously the include path was {INSTALL_PREFIX}/include,
it is now {INSTALL_PREFIX}/include/SDL2 to be consistent with
the other build and package configuration systems.

Fixes #4128.
Sam Lantinga
Fixed build
Sam Lantinga
Fixed return value
Sam Lantinga
Temporary fix for bug 3432 - macOS 10.12: small scrolls (1 wheel notch) don't generate events

Eric Wasylishen

This bug was reintroduced by https://hg.libsdl.org/SDL/rev/68a80d7afec3

The steps to reproduce are the same: run the "testrelative" SDL demo with "--info all",
connect a USB mouse with a scroll wheel, and roll the scroll wheel one "notch". You'll get log output like:

testdraw2[1644:67222] INFO: SDL EVENT: Mouse: wheel scrolled 0 in x and 0 in y (reversed: 1) in window 1

As far as I can tell macOS doesn't have an API for getting the number of "wheel notches"; I get a deltaY of 0.100006 for one "notch", and it's heavily accelerated (if you roll the wheel quickly you'll get large deltas). So NSEvent's deltaY is only meant to be used for scrolling a scroll view, with the given distance in points, not something like selecting an item in a game.

Here's a temporary patch that at restores the foor/ceil in Cocoa_HandleMouseWheel.
Not ideal, but at least it restores the ability to scroll one notch of a mousewheel.
Sam Lantinga
Handle NULL return from SDL_DBus_GetContext()
Sam Lantinga
Fixed bug 4108 - Missing break statements in SDL_CDResume and SDL_CDStop

Ozkan Sezer

Two break statements are missing in SDL_cdrom.c:SDL_CDResume()
and SDL_CDStop(), which negate the returned code from driver
and always return 0.  The following patch adds those breaks.
Sam Lantinga
Added support for the GameSir G3w
Sam Lantinga
TryLockMutex: Fix error handling for TryLockMutex

Christian Herzig

pthread_mutex_trylock() and by the way, pthread_mutex_lock() do not set errno.
Pthread-methods directly return error code as int. See related man-pages for
details.
Ryan C. Gordon
wayland: zxdg_shell_v6 needs a configure event before using a surface at all.

Fixes Bugzilla #4109.
Fixes Bugzilla #4119.
Sam Lantinga
Fixed bug 4144 - CMake complains about trailing spaces in sdl2.pc

Azamat H. Hackimov

When you try use SDL2 2.0.8 in CMake project in Linux, it complains about trailing spaces in sdl2.pc:

CMake Error at CMakeLists.txt:147 (add_executable):
  Target "TestSimpleMain" links to item "-L/usr/lib64 -lSDL2 " which has
  leading or trailing whitespace.  This is now an error according to policy
  CMP0004.